Issue #130 #138
Merged
Issue #130 #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Date, endDate and duration.
vikasrohit
reviewed
Jul 28, 2018
| projectId: newProject.id, | ||
| name: _.get(phase, 'name', `Stage ${phaseIdx}`), | ||
| duration: _.get(phase, 'duration', 0), | ||
| duration, | ||
| startDate: startDate.format(), |
There was a problem hiding this comment.
@architectt1 Can we make sure that any date field does not persist time of the day in database. We kept the field to be datetime for future, but don't want to add the time details for date fields. I mean, it should always represent 00:00:00.000 in database.
There was a problem hiding this comment.
Assertion in unit test would be great to validate this.
There was a problem hiding this comment.
@vikasrohit done in de0d52e.
vikasrohit
approved these changes
Jul 30, 2018
|
@coderReview merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a project from a project template, define phases'
startDate,endDateandduration.